Much more powerful check command, and new recover command
#6772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/recover-json
branch
2 times, most recently
from
13d668e
to
d9028e3
Compare
rustyrussell
force-pushed
the
guilt/recover-json
branch
2 times, most recently
from
ff10663
to
d1cae99
Compare
``` **BROKEN** connectd: dev_report_fds: 5 open but unowned? ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…cking. We often want to do more parameter checks after param(), so allow a new param_check(), with the proviso that the caller needs to also return command_check_done() after other checks if command_check_only(cmd) is true. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… write to db. Put an assertion inside db.c, and run every command we do (in testing) through a `check` variant. I inserted a deliberate bug (made addpsbtoutput call wallet_get_newindex() before returning when running `check`, and indeed, backtrace as expected. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/recover-json
branch
from
d1cae99
to
c39ba8d
Compare
We already do this in param_invstring now. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This makes `check` much more thorough, and useful. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: JSON-RPC: `check` now does much more checking on every command (not just basic parameter types).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: Config: `--recover` can take a 32-byte hex string, as well as codex32.
Changelog-Added: JSON-RPC: `recover` command to force (unused) lightningd node to restart with `--recover` flag. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/recover-json
branch
from
c39ba8d
to
598c809
Compare
endothermicdev
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Looks great. I like the added check functionality and test coverage.
ACK 598c809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6616
With a fairly simple sweep, I could make
checkpowerful enough thatcheck recoverdoes what the proposedrecover-possiblecommand was for. Overall, really happy with this change!So now, you can get a node to recover through the RPC api, great for front-ends like RTL, Zeus, etc.