Simplify use of channel_update #6786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`[False]` is considered True in Python, so this flake fix didn't work.
```
>>> if [False]:
... print('x')
...
x
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/fix-empty-update
branch
from
174a32a
to
16ef47a
Compare
This is far simpler: lightningd no longer needs to tell channeld when updates change, etc. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…edundant. channeld used to talk directly to gossipd, so it made sense for it to tell gossipd directly when it wanted it to make a new channel_update. When that changed with v0.11, we simply directed the message via lightningd. But much of the information is actually told to channeld by lightningd! So I applied this assertion and ran the test suite, before the next patch makes it redundant. We got one assertion: test_setchannel_zero deliberately drives the advertized htlc_max over the real htlc max in test_setchannel_zero for testing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…ble_flag' Rename it to `enable` and invert it everywhere. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… channel_update. Now we've asserted that channeld would tell lightningd the same thing it would do anyway, we can simply have channeld say "enable=True|False" and lightningd fill in the other fields. This means there's a pile of things channeld doesn't need to know any more! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/fix-empty-update
branch
from
16ef47a
to
fde56fd
Compare
|
Very nice cleanup 👍 ACK fde56fd |
cdecker
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only the beginning of the cleanup I wanted to perform, but the rest requires that gossipd no longer handle private gossip, which will not be in this release.
Nonetheless, this removes some fairly complex code, so nice to have: channeld used to make the updates, and tell lightningd to tell gossipd, and now lightningd does it itself.