clnrest: Import sys in except clause explicitly #6883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add a check for this? |
This fixes a crash on startup of core-lightning where gevent could not be imported. This happens before sys is imported and throws us into the except clause which calls sys. By importing it explicitly in the except clause we are not dependend of the order of imports in the try bracket. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com> Changelog-Fixes: Plugin: clnrest crashed on startup when gevent was missing.
nepet
force-pushed
the
202311-fix-clnrest-startup-crash
branch
from
44878ca
to
79e9f76
Compare
ShahanaFarooqui
requested changes
Nov 20, 2023
|
Moving the sys import up to the top will also resolve the issue but comes with the risk that we forget about this in the future and make the same mistake again. Importing it explicitly removes this risk. Importing a module twice will ignore the second import and just give a reference to the module that has already been imported so this should not add overhead(?). |
ShahanaFarooqui
approved these changes
Nov 20, 2023
|
ACK 79e9f76. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash on startup of core-lightning where gevent could not be imported. This happens before sys is imported and throws us into the except clause which calls sys.
By importing it explicitly in the except clause we are not dependend of the order of imports in the try bracket.