coin_mvt: use the lightning_hrp for *all* coin movement currency
#6888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were (dumbly?) using the `onchain_hrp` for 'chain_mvts' and the `lightning_hrp` for 'channel_mvts'. This works fine everywhere *except* for on a signet, where we use different prefixes. Since the lightning-hrp set is more diversified (testnet btc + signet btc use the same HRP 'onchain'), let's use that. Should have zero impact on anything other than nodes running on signet. To preserve your current accounts database without needing to delete, restart, execute the following: (note preferrably when your node isn't running). ``` UPDATE chain_events SET currency = 'tbs' WHERE currency = 'tb'; ``` Fixes ElementsProject#6534 Changelog-Fixed: `bkpr-listbalances` would crash for nodes on signet with payments in channels, because onchain events were using a different currency than inchannel events.
vincenzopalazzo
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were (dumbly?) using the
onchain_hrpfor 'chain_mvts' and thelightning_hrpfor 'channel_mvts'.This works fine everywhere except for on a signet, where we use different prefixes.
Since the lightning-hrp set is more diversified (testnet btc
Should have zero impact on anything other than nodes running on signet.
To preserve your current accounts database without needing to delete, restart, execute the following: (note preferrably when your node isn't running).
Fixes #6534
Changelog-Fixed:
bkpr-listbalanceswould crash for nodes on signet with payments in channels, because onchain events were using a different currency than inchannel events.