Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 32-bit status_debug fix #6890

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

arowser
Copy link
Contributor

@arowser arowser commented Nov 22, 2023

FIx build error on 32bit system:

cc channeld/channeld.c
In file included from channeld/channeld.c:41:
channeld/channeld.c: In function ‘peer_reconnect’:
channeld/channeld.c:5149:15: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 6 has type ‘size_t’ {aka ‘unsigned int’} [-Werror=format=]
 5149 |  status_debug("Got reestablish commit=%"PRIu64" revoke=%"PRIu64
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
./common/status.h:41:28: note: in definition of macro ‘status_debug’
   41 |  status_fmt(LOG_DBG, NULL, __VA_ARGS__)
      |                            ^~~~~~~~~~~
channeld/channeld.c:5150:23: note: format string is defined here
 5150 |        " inflights: %lu, active splices: %"PRIu32,
      |                     ~~^
      |                       |
      |                       long unsigned int
      |                     %u

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 98add9c

@rustyrussell rustyrussell added this to the v23.11.1 milestone Dec 14, 2023
@rustyrussell rustyrussell merged commit 34a3236 into ElementsProject:master Dec 14, 2023
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants