Fix getemergency segfault #6895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused a segmentation fault when calling `getcodexsecret` without id. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com> Changelog-Fixed: Hsmtool: Fix segmentation fault when calling `getcodexsecret` without id.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
I guess this was to honor Aditya, but it was also a wrong example. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
|
Good catch @nepet :) |
|
ACK 91e81f8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getemergencyrecovergetcodexsecretas it contained a disallowed characteri. I guess this was an honor to @adi2011 so sorry for the change (shall we keep it? ^^).