Expose listoffer and offer over grpc
#6896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
20231122-offer-grpc
branch
2 times, most recently
from
09423a5
to
b772640
Compare
|
Looks like the "flexibility" of having multiple different ways to specify a recurrence is biting us here. We should really consolidate on one way to express things, and deprecate the alternative uses. This ought to simplify the schema, as well as supporting the functionality going forwards. WDYT @rustyrussell? Ideally I'd like to just use the string variant, as that seems to be expressive enough. |
cdecker
force-pushed
the
20231122-offer-grpc
branch
from
f1b0276
to
23085b2
Compare
|
See #7034 |
cdecker
force-pushed
the
20231122-offer-grpc
branch
from
23085b2
to
46b4664
Compare
|
Rebased on top of #7034 to fold the simplification of arguments in |
The `amount` field is intended to be either a native unit (`msat`, `sat` or `btc`) or it can also be a non-native unit that needs to be converted into native when creating the invoice. As such limiting the `amount` to only be native is very restrictive.
I had to do some trickery with the interchangeability between string and int, but now it works as expected.
cdecker
force-pushed
the
20231122-offer-grpc
branch
from
46b4664
to
a47d699
Compare
|
The schema had a minor issue with the stringified variants and the object variants. The object variant isnt accessible from the RPC, rather we must use the string variant. This now passes the tests. Also rebased on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6892
I was unsure of some of the protobuf definitions for the
recurrence-related types, had to take a look at bolt12.c and see from there. Definitely requires a second look.Currently missing:
rootdirpositional argument after being installed and sourced, will check)