Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splice: Complete tx_abort implementation #6940

Merged
merged 9 commits into from
Feb 11, 2024
Merged

Splice: Complete tx_abort implementation #6940

merged 9 commits into from
Feb 11, 2024

Commits on Feb 10, 2024

  1. dualopen: update test to handle ABORT 

    In he case of initiating an RBF, ABORT is used instead of ERROR.
    @ddustin
    ddustin committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    de8faf8 View commit details
    Browse the repository at this point in the history

  2. inflight: Add ability to delete an inflight

    @ddustin
    ddustin committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    7074a55 View commit details
    Browse the repository at this point in the history

  3. interactive_tx: Add tx_abort support 

    We add checks for tx_abort and pass them back up to be handled.
    @ddustin
    ddustin committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    a9dd383 View commit details
    Browse the repository at this point in the history

  4. lightningd: Add tx_abort routine to lightningd 

    Lightningd is responsible to restart channeld when it gets this message.
    @ddustin
    ddustin committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    62dcf7e View commit details
    Browse the repository at this point in the history

  5. splice: Add support for tx_abort to channeld 

    Add checking for and sending tx_abort to channeld.

When receiving it we first ACK it back, send a request to restart to lightningd, and then shutdown channeld.

We also must update the splice tests that relied on reconnect checks for splice warnings (as some are now tx_aborts instead).
    @ddustin
    ddustin committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    27e5af8 View commit details
    Browse the repository at this point in the history

  6. splice: Add support for out-of-bound tx_sig 

    If the peer isn’t required to send signatures first but does while we are awaiting the next user RPC action — we should be caching the message and using it later.

Before we would leave the message cached in the socket itself, but tx_abort semantics require us to check the socket more often.
    @ddustin
    ddustin committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    1c78553 View commit details
    Browse the repository at this point in the history

  7. fixup! splice: Add support for tx_abort to channeld

    @ddustin
    ddustin committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    f9d221e View commit details
    Browse the repository at this point in the history

  8. fixup! inflight: Add ability to delete an inflight

    @ddustin
    ddustin committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    4a12580 View commit details
    Browse the repository at this point in the history

  9. fixup! lightningd: Add tx_abort routine to lightningd

    @ddustin
    ddustin committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    d97e3aa View commit details
    Browse the repository at this point in the history