Dual-funding: permit re-negotiation of require-confirmed on RBFs #6945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/df-require-unconf-rbf
branch
from
94f8b3a
to
82749ff
Compare
cdecker
force-pushed
the
nifty/df-require-unconf-rbf
branch
from
82749ff
to
0159ec4
Compare
We now require peers to reaffirm their preference for `require_confirmed_inputs` when executing an RBF. Requested-By: @t-bast
cdecker
force-pushed
the
nifty/df-require-unconf-rbf
branch
from
0159ec4
to
736f8ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be explicit about the
require-confirmedrequirements for RBFs as well as initial txs.Updates CLN to conform to the latest spec draft, including lightning/bolts@27ffef4
Be explicit about the require-confirmed requirements for RBFs as well as initial txs.
Initially we were re-using the value at start for any subsequent renegotiations, but with this patch we
now use whatever the system-wide setting is at the time that we attempt an RBF. This makes it easier to test
and allows you to (with some effort) update what channels request at a system level.
Requested-By: @t-bast