repro: multifundchannel and all amount
#7037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On mainnet this has the consequence of pending channels for 2 weeks and no way to open to most peers in that time since they only allow 1 pending channel at the same time. So no way to get liquidity to the same node for 2 weeks, even if you forget about the channel on cln's side, lnd nodes wont forget them without manual intervention. |
|
Mh this looks like a bug! thanks for reproducing it |
cdecker
added
the
state::repro
cdecker
changed the title
multifundchannel and all amount
|
The amounts of the regular destinations seem to not be subtracted from the "all" amount destination |
…all"). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We tried to put *everything* into the "all" output, which didn't work if there were other outputs! Fixes: ElementsProject#6664 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: JSON-RPC: `multifundchannel` with `all` as an amount works as expected.
rustyrussell
force-pushed
the
multifund-all
branch
from
8221ab4
to
d4abea3
Compare
|
Great report! How's this? |
|
I've ran a bunch of tests on it and it works! Thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #6664
Using
"amount": "all"is atleast in multifundchannel broken. I could not find a test for it so i wrote a simple test for it. Didn't know 100% where to put it or what to put for the@, but this test fails with:important part:
value in (0.02) < value out (0.02045073)Expectation is that this test passes and not tries to inflate bitcoin.