Fix close fail retry #7072
Merged
Fix close fail retry #7072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Tabs vs spaces, it's weird. No code changes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/fix-close-fail-retry
branch
2 times, most recently
from
4c74ff4
to
ce62b47
Compare
We do `memeq(a, tal_bytelen(a), b, tal_bytelen(b))` remarkably often... Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…tination. Watchtowers changed the code so that we *always* have a channel->shutdown_scriptpubkey[LOCAL] (see new_channel()). The previous code had several problems: 1. It tested this for NULL, unnecessarily. 2. It allowed overriding if it was a default, *even* if we were already using it. 3. If the peer opened without option_shutdown_anysegwit, but upgraded before we closed, we would not recognize the default. 4. It set the final scriptpubkey (and other things!) even if the command failed. Changelog-Fixed: JSON-RPC: `close` with `destination` works even if prior `destination` was rejected. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…isting nodes. This will solve the problem for users who already hit the bug fixed by the previous patch! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/fix-close-fail-retry
branch
from
ce62b47
to
9376425
Compare
|
Changed to fix typos in fuzzing and make typecheck in tal_arr_eq more general. |
|
ACK 9376425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are actually other bugs in the same logic, so it would be nice to fix.
Fixes #7014