Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renepay fix fees #7082

Merged
merged 3 commits into from Feb 16, 2024
Merged

Renepay fix fees #7082

merged 3 commits into from Feb 16, 2024

Conversation

Lagrang3
Copy link
Collaborator

Whenever there is a payment failure that requires gossip update, for
example changing the fee rates of remote channels, we call addgossip.
For renepay to consider this changes in the coming payment attempts, it
must update gossmap.

Fixes issue #7081

- previous pending sendpays must add up so that the plugin tries to pay
the rest of the amount,
- avoid groupid, partid collisions,
- add shadow fees if the option is set and the payment amount - total
  delivering = 0
- add a test,
- also fix a buggy shadow routing test
Whenever there is a payment failure that requires gossip update, for
example changing the fee rates of remote channels, we call addgossip.
For renepay to consider this changes in the coming payment attempts, it
must update gossmap.
@cdecker
Copy link
Member

cdecker commented Feb 16, 2024

Thanks for formatting the test_renepay.py file, I think this is perfect as it is pretty much your own file. I have been considering the use of the pre-commit tool to put some of the files under lint and formatter control, and we'd pick one file at a time to add to the coverage. Does that sounds useful?

ACK 8974b83

@cdecker cdecker merged commit c916066 into ElementsProject:master Feb 16, 2024
36 checks passed
@Lagrang3 Lagrang3 deleted the renepay-fix-fees branch February 17, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants