Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of EOL deprecations for 23.05 #7094

Merged
merged 14 commits into from
Mar 25, 2024
Merged

Removal of EOL deprecations for 23.05 #7094

merged 14 commits into from
Mar 25, 2024

Commits on Mar 25, 2024

  1. lightningd: fix name for deprecated APIs, and fix crash with listconf… 

    …igs when --i-promise-to-fix-broken-api-user is used.

We were duplicating the command name (e.g. "autocleaninvoice.autocleaninvoice"), and also not
handling listconfigs if they specified the (currently unused!) i-promise-to-fix-broken-api-user
option, which we are going to use next patch.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    6e8d40e View commit details
    Browse the repository at this point in the history

  2. Makefile: update CLN_NEXT_VERSION so deprecations tick over. 

    Indeed, we now need to adjust our tests to use --i-promise-to-fix-broken-api-user
for the specific APIs past end-of-life.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    bc048af View commit details
    Browse the repository at this point in the history

  3. lightningd: remove failure_code from invoice hook and htlc_accepted h… 

    …ook.

These were deprecated in v22.08 (invoice hook) and v0.8 (htlc_accepted hook), and
marked EOL in v23.02.

*PLEASE* complain if this breaks things for you: it's kind of a test canary of
the deprecation system!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Removed: Plugins: `invoice_payment` and `htlc_accepted` hook `failure_code` response (derepcated v22.08 and v0.8, EOL v23.02)
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    6f2adc3 View commit details
    Browse the repository at this point in the history

  4. lightnind: remove deprecated feerate names. 

    Changelog-Removed: JSON-RPC feerates by internal names ("opening", "mutual_close", "delayed_to_us", "htlc_resolution", "penalty", "min_acceptable", "max_acceptable") (deprecated v23.05, EOL v24.02).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    7d85056 View commit details
    Browse the repository at this point in the history

  5. lightningd: remove delexpiredinvoice 

    Changelog-Removed: JSON-RPC: `delexpiredinvoice` (deprecated v22.11, EOL v24.02)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    9f0c669 View commit details
    Browse the repository at this point in the history

  6. doc: correctly remove generated schemas on make clean. 

    We also remove manpages, since they're no longer in git anyway.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    76b8af6 View commit details
    Browse the repository at this point in the history

  7. autoclean: remove deprecated configs. 

    Changelog-Removed: Config: `autocleaninvoice-cycle` and `autocleaninvoice-expired-by` (deprecated v22.11, EOL v24.02)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    b6e96b1 View commit details
    Browse the repository at this point in the history

  8. lightningd: remove obsolete feerate output fields. 

    Changelog-Removed: JSON-RPC: `feerates` output fields `delayed_to_us` and `htlc_resolution`.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    2d41800 View commit details
    Browse the repository at this point in the history

  9. lightningd: remove funding_locked from channel_opened notification. 

    Changelog-Removed: Plugins: `funding_locked` from channel_opened notification (deprecated v22.11, EOL v24.02)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    79200b3 View commit details
    Browse the repository at this point in the history

  10. lightningd/connectd: remove --experimental-websocket-port 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Removed: Config `experimental-websocket-port` (deprecated 23.08, EOL 24.02)
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ca342d6 View commit details
    Browse the repository at this point in the history

  11. lightningd: remove handling of invalid sendpay route first channel 

    Changelog-Removed: JSON-RPC: `sendpay` ignoring first channel (deprecated v0.12, EOL v24.02)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    637fd96 View commit details
    Browse the repository at this point in the history

  12. lightningd: remove channels from listpeers. 

    Changelog-Removed: JSON-RPC: `listpeers` `channels` (deprecated v23.02, EOL v24.02)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    857a55c View commit details
    Browse the repository at this point in the history

  13. lightningd: remove createrune restrictions as strings. 

    Changelog-Removed: JSON-RPC: `createrune` restrictions as raw strings (use arrays) (deprecated v23.05, EOL 24.02).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    0e3bb37 View commit details
    Browse the repository at this point in the history

  14. plugins: remove allowance for missing JSON id in commando. 

    Changelog-Removed: Plugins: no longer allow missing `id` field in commando requests (deprecated v23.02, EOL v24.02)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    fae2f9f View commit details
    Browse the repository at this point in the history