Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx_parts: use wally to clone tx inputs #7099

Merged
merged 1 commit into from Feb 21, 2024

Conversation

jgriffiths
Copy link
Contributor

@jgriffiths jgriffiths commented Feb 20, 2024

Update to clone inputs as we do outputs already. Aside from requiring less code, this insulates us from any future wally changes to add new members inside the tx struct.

This is possible since the version bump to wally 1.2 now exposes the input clone function.

Changelog-None

Signed-off-by: Jon Griffiths <jon_p_griffiths@yahoo.com>
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2df30da

@cdecker cdecker merged commit 6fffba0 into ElementsProject:master Feb 21, 2024
36 checks passed
@jgriffiths jgriffiths deleted the remove_tx_parts branch February 21, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants