Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pay: Prevent duplicate preapproveinvoice calls #7121

Merged
merged 1 commit into from
Mar 6, 2024
Merged

pay: Prevent duplicate preapproveinvoice calls #7121

merged 1 commit into from
Mar 6, 2024

Commits on Mar 1, 2024

  1. pay: Prevent repeating the preapproveinvoice check 

    So far we would call `preapproveinvoice` once for each payment split,
i.e., at least once per HTLC, and potentially more often. There is no
point in doing so repeatedly, and especially in remote signer setup
this is actually counterproductive due to the additional roundtrips.

Changelog-Changed pay: Improved performance by removing repeated `preapproveinvoice` calls
    @cdecker
    cdecker committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    dd4ec39 View commit details
    Browse the repository at this point in the history