Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part pay support #7145

Merged
merged 2 commits into from Mar 20, 2024
Merged

Conversation

rustyrussell
Copy link
Contributor

Thanks to prodding from @callebtc

@cdecker
Copy link
Member

cdecker commented Mar 14, 2024

Great work, I can drop my half-finished PR then ^^

As usualy some bikeshedding about names: part_msat sounds too close to part which is what we call a signle HTLC attempt in an MPP, and is used in part_id. We probably don't want to mix the two, as they are similar both in name as well as adjacent scopes.

partial_msat, deliver_msat or send_only_msat?

@rustyrussell
Copy link
Contributor Author

Agreed, renaming it partial_msat...

At the moment they're both the same, but we're about to change that.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
a.k.a. "Pay with a friend!".

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: JSON-RPC: `pay` has a new parameter `partial_msat` to only pay part of an invoice (someone else presumably will pay the rest at the same time!)
Suggested-by: Calle
@rustyrussell rustyrussell merged commit 4a9b9b8 into ElementsProject:master Mar 20, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants