offers: fix our blinded path setting in invoices #7311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
approved these changes
May 14, 2024
There was a problem hiding this comment.
ACK 83cb66d
I pile my ACK on top of the #7304 where thsi PR is based
I think by the next few days I should be able to test the iterop with ldk by running https://github.com/vincenzopalazzo/lampo.rs/blob/main/tests/tests/src/lampo_cln_tests.rs#L372
Comment on lines
+1232
to
+1234
| rpc_scan(p, "getchaininfo", | ||
| take(json_out_obj(NULL, "last_height", "0")), | ||
| "{headercount:%}", JSON_SCAN(json_to_u32, &blockheight)); |
There was a problem hiding this comment.
Bloody hell! good catch!
| struct tlv_encrypted_data_tlv_payment_relay *payment_relay, | ||
| struct tlv_encrypted_data_tlv_payment_constraints *payment_constraints, | ||
| u8 *path_secret, | ||
| struct pubkey *node_alias) | ||
| { | ||
| struct tlv_encrypted_data_tlv *tlv = tlv_encrypted_data_tlv_new(tmpctx); | ||
|
|
||
| tlv->short_channel_id = next_scid; | ||
| tlv->next_node_id = cast_const(struct pubkey *, next_node_id); |
There was a problem hiding this comment.
I did not know about this cast_const, ccan is like the std that C should have
endothermicdev
force-pushed
the
guilt/fix-blinded-path-cltv
branch
from
83cb66d
to
79f155b
Compare
endothermicdev
force-pushed
the
guilt/fix-blinded-path-cltv
branch
from
79f155b
to
e0275a7
Compare
|
trivial bolt quote and spelling fixup |
This demonstrates a number of issues reported by Carla: no surprise since there was no test! (We create a one-hop blinded path when we only have private channels). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
At plugin startup, we don't have an accurate blockheight and can get 0! Fixes: ElementsProject#7161 Reported-by: @carlaKC Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Without this, it was broken because our peer will no longer forward via scids for private channels. We could use the scid alias, but the node id is right at hand. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…info. It should probably be renamed "minimum_cltv_delta" or something. Fixes: ElementsProject#7179 Reported-by: @carlaKC Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
The spec has moved a bit here: the `outgoing_cltv_value` in the final onion is basically the blockheight now (plus the 1 block delta we give ourselves). Also, we were doubling ours, since p->min_final_cltv_expiry was already set to p->blindedpay->cltv_expiry_delta above. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/fix-blinded-path-cltv
branch
from
e0275a7
to
2f7d79e
Compare
|
Trivial rebase after other merges |
endothermicdev
approved these changes
May 15, 2024
| offer = l3.rpc.offer(1000, 'test_pay_blindedpath_privchan') | ||
| l1.rpc.decode(offer['bolt12']) | ||
|
|
||
| inv = l2.rpc.fetchinvoice(offer['bolt12']) |
There was a problem hiding this comment.
Why does l2 fetch rather than l1?
endothermicdev
merged commit 3c48438
into
ElementsProject:master
27 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix pay to pay them properly too!
Thanks @carlaKC for the reports!
Closes: #7161
Closes: #7179