Fix crash when trying to forget a channel with HTLCs #987
Conversation
Will be used when forgetting peer as well. Signed-off-by: Christian Decker <decker.christian@gmail.com>
Check if we have HTLCs, if yes force=true is required. Signed-off-by: Christian Decker <decker.christian@gmail.com>
Signed-off-by: Christian Decker <decker.christian@gmail.com>
|
Yech :( I'm pretty sure that this code will just destabalize the system, by unpairing existing HTLCs which are coming/going to other peers. We assume that doesn't happen as the entire system is designed to avoid that. IOW, dev-forgetpeer was much harder than we thought. It needs to fail the corresponding incoming HTLCs for every outgoing HTLC we just deleted, and similarly make sure we now handle the replies for outgoing HTLCs which now don't have a matching incoming... |
|
That's the reason to have it being That being said, with #975 it should become much less important to clear a channel since a dead channel no longer prevents you from opening a new one. |
|
No, the user is explicitly using it for non-testing! We need to fix the real problem, I think. |
Reported by @sfmcnally in #946
Will likely need to adapted should #975 get in first.
Fixes #946