encode: Revert io::BufRead requirement on Encodable trait #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We really never should have required BufRead just to make the commitment parsing a tad more convenient.
apoelstra
approved these changes
Jun 9, 2022
This kinda makes the Decodable impls on these types unnecessary, but I'm not against keeping them around just in case anyone wants them. It also makes this whole change backwards compatible.
|
Btw, I think this change can be considered non-breaking. I don't remove the now-unused trait impls and BufRead is a struct supertrait of Read. |
apoelstra
approved these changes
Jun 9, 2022
|
Agreed that it's non-breaking. |
sanket1729
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
ACK c1a7641. Commitment and Generator are Copy. There is no allocation in them. I would like to keep the decodable Impls because they can come in handy in downstream repos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really never should have required
BufReadjust to make the commitment parsing a tad more convenient.