Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove std feature gates #164

Merged
merged 1 commit into from
May 11, 2023
Merged

Remove std feature gates #164

merged 1 commit into from
May 11, 2023

Conversation

uncomputable
Copy link
Contributor

There is no std feature in rust-elements. This is a copy-and-paste error from rust-bitcoin.

@uncomputable
Copy link
Contributor Author

error: There are multiple syn packages in your project, and the specification syn is ambiguous.

I feel this is not from my PR. CI broke again?

apoelstra
apoelstra approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b14f1a3

@apoelstra
Copy link
Member

@uncomputable yes, CI is broken because of syn (which I thought we'd fixed many weeks ago..) and because we need doc comments on pub extern crate now (this one is new).

@apoelstra apoelstra merged commit eba8e71 into ElementsProject:master May 11, 2023
3 of 5 checks passed
@uncomputable uncomputable deleted the std-feature branch May 11, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uncomputable @apoelstra