Add to and from base64 string to pset #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCasatta
changed the title
RCasatta
force-pushed
the
pset_str
branch
2 times, most recently
from
86f2ae8
to
5f8fb1b
Compare
|
@RCasatta, there is a clippy warning. For the MSRV fixes, you can refer to the rust-bitcoin cargo.toml file. |
via standard trait Display and FromStr like it's done in rust-bitcoin PSBT. Reuse rust-bitcoin base64 re-exported
|
@sanket1729 CI for 1.48.0 and clippy fixed |
delta1
approved these changes
Sep 14, 2023
sanket1729
added a commit
that referenced
this pull request
Sep 22, 2023
ed066af rename pset::str::Error to ParseError and expose it (Riccardo Casatta) Pull request description: Otherwise the pset decoding from string cannot be used downstream fix #175 ACKs for top commit: apoelstra: ACK ed066af sanket1729: ACK ed066af Tree-SHA512: 7ee8346ddea5b6bfa21bdc8fbf0a4fb23ab056821625f0bb67b7b8c271b3c6570f2c431fc0f23f6ee04c025f240d0b7a72a3849e64cd143de4563bfba9634721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via standard trait Display and FromStr like it's done in rust-bitcoin PSBT.
Reuse rust-bitcoin base64 re-exported