Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package composer 2 compatible #33

Merged
merged 9 commits into from
Oct 20, 2020
Merged

Make package composer 2 compatible #33

merged 9 commits into from
Oct 20, 2020

Conversation

BramG
Copy link
Contributor

@BramG BramG commented Oct 13, 2020

Didnt, try to push yet.
But the composer require didn't fail anymore.

Tested with:
curl https://getcomposer.org/composer-2.phar --output composer-2.phar

@Elendev
Copy link
Owner

Elendev commented Oct 19, 2020

Hi @BramG, thanks for this PR!
Can you also update the GH Actions build to support Composer 2 in the build matrix?

https://github.com/Elendev/nexus-composer-push/blob/master/.github/workflows/testing-and-cs.yaml#L27

Thanks!

@BramG
Copy link
Contributor Author

BramG commented Oct 19, 2020

@Elendev I need some help, looking at the documentation https://github.com/marketplace/actions/setup-php-action using v2 should work but it isn't. I tried to execute the composer require with composer 2 locally and it works perfectly...

@BramG
Copy link
Contributor Author

BramG commented Oct 19, 2020

It's green!

Copy link
Owner

@Elendev Elendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BramG for your contribution!

@Elendev Elendev merged commit 9680c2e into Elendev:master Oct 20, 2020
@Elendev
Copy link
Owner

Elendev commented Oct 20, 2020

@BramG I've released 0.3.0, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants