no clear error when channel opening failing when no room in utxos for change #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodriFS
commented
Feb 12, 2024
Comment on lines
-235
to
-239
| else if (selectedUTXOsValue > maxChannelRegtestValue && network == Network.RegTest && IsWalletWithdrawalValidation) | ||
| { | ||
| e.ErrorText = $"The combined amount of the UTXOs selected must be lower than {maxChannelRegtestValue:f8} BTC"; | ||
| e.Status = ValidationStatus.Error; | ||
| } |
There was a problem hiding this comment.
since we can do coin selection with change, this doesn't make sense anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no way to calculate the fees before the PSBT is generated, we can't warn the user that there is no room in utxos for fees when doing operations with change. At least now there is a warning if the amount is equal which might happen if the user forgets to click on changeless. And also added a clear error message (visible to the user) when this happens