Standardized code in all of core, not including language files, tests…

…, or core mods.

git-svn-id: http://code.elgg.org/elgg/trunk@7124 36083f99-b078-4883-b0ff-0f9b5a30f544

CHANGES.txt

@@ -8,8 +8,35 @@ Version 1.8.0 (Jackie)
  Generic API changes:
   * Added elgg_instanceof().
   * Added remove_subtype() and update_subtype().
-  * Added elgg_format_url()
-
+  * Added elgg_format_url().
+  * ElggDiskFilestore supports non-user owners.
+
+ Deprecated APIs:
+  * ElggAccess::get_ignore_access() by ElggAccess::getIgnoreAccess().
+  * ElggAccess::set_ignore_access() by ElggAccess::setIgnoreAccess().
+  * ElggCache::set_variable() by ElggCache::setVariable().
+  * ElggCache::get_variable() by ElggCache::getVariable().
+  * ElggDiskFilestore::make_directory_root() by ElggDiskFilestore::makeDirectoryRoot().
+  * ElggDiskFilestore::make_file_matrix() and ElggDiskFilestore::user_file_matrix() by
+    ElggDiskFilestore::makeFileMatrix().
+  * ElggDiskFilestore::mb_string_split() removed.
+  * ElggEntity::initialise_attriutes() by ElggEntity::initializeAttributes(). Same for
+    all sub classes of ElggEntity.
+  * ElggFileCache::create_file() by ::createFile().
+  * ElggFileCache::sanitise_filename() by ::sanitizeFilename().
+  * ElggMemcache::make_memcache_key() by ::_makeMemcacheKey().
+  * ElggGroup::initialise_attributes() by ::initializeAttributes().
+  * ElggPlugin::initialise_attributes() by ::initializeAttributes().
+  * XMLRPCCall::parse() by XMLRPCCALL::_parse().
+  * __get_annotations_calculate_x() by get_annotations_calculate_x().
+  * __get_entities_from_annotations_calculate_x() by get_entities_from_annotations_calculate_x().
+  * __php_api_error_handler() by _php_api_error_handler().
+  * __php_api_exception_handler() by _php_api_exception_handler().
+  * __elgg_php_error_handler() by _elgg_php_error_handler().
+  * __elgg_php_exception_handler() by _elgg_php_exception_handler().
+  * __process_element() by _process_element().
+  * All __elgg_session_*() by _elgg_session_*().
+
  UI/UX API changes:
   * Added elgg_push_breadcrumb(), elgg_pop_breadcrumb(), and elgg_get_breadcrumbs().
   * Added navigation/breadcrumbs.

_css/css.php

@@ -30,7 +30,7 @@
 $viewinput['viewtype'] = $_GET['viewtype'];
 
 header("Content-type: text/css", true);
-header('Expires: ' . date('r',time() + 86400000), true);
+header('Expires: ' . date('r', time() + 86400000), true);
 header("Pragma: public", true);
 header("Cache-Control: public", true);
 

_css/js.php

@@ -33,7 +33,7 @@
 $viewinput['viewtype'] = $_GET['viewtype'];
 
 header('Content-type: text/javascript');
-header('Expires: ' . date('r',time() + 864000000));
+header('Expires: ' . date('r', time() + 864000000));
 header("Pragma: public");
 header("Cache-Control: public");
 

actions/admin/menu_items.php

@@ -29,7 +29,7 @@
 // save the custom items
 $custom_count = count($custom_item_names);
 $custom_items = array();
-for ($i=0; $i<$custom_count; $i++) {
+for ($i = 0; $i < $custom_count; $i++) {
 	if (isset($custom_item_names[$i]) && isset($custom_item_names[$i])) {
 		$name = $custom_item_names[$i];
 		$url = $custom_item_urls[$i];

actions/admin/plugins/simple_update_states.php

@@ -23,7 +23,8 @@
 
 foreach ($installed_plugins as $plugin => $info) {
 	// this is only for simple plugins.
-	if (!isset($info['manifest']['admin_interface']) || $info['manifest']['admin_interface'] != 'simple') {
+	$interface_type = elgg_get_array_value('admin_interface', $info['manifest'], NULL);
+	if (!$interface_type || $interface_type != 'simple') {
 		continue;
 	}
 

actions/comments/add.php

@@ -2,7 +2,8 @@
 /**
  * Elgg add comment action
  *
- * @package Elgg
+ * @package Elgg.Core
+ * @subpackage Comments
  */
 
 // Make sure we're logged in; forward to the front page if not
@@ -27,11 +28,11 @@
 
 $user = get_loggedin_user();
 
-$annotation = create_annotation($entity->guid, 
+$annotation = create_annotation($entity->guid,
 								'generic_comment',
-								$comment_text, 
-								"", 
-								$user->guid, 
+								$comment_text,
+								"",
+								$user->guid,
 								$entity->access_id);
 
 // tell user annotation posted
@@ -42,7 +43,7 @@
 
 // notify if poster wasn't owner
 if ($entity->owner_guid != $user->guid) {
-			
+
 	notify_user($entity->owner_guid,
 				$user->guid,
 				elgg_echo('generic_comment:email:subject'),
@@ -59,8 +60,9 @@
 }
 
 system_message(elgg_echo("generic_comment:posted"));
+
 //add to river
-add_to_river('annotation/annotate','comment',$user->guid,$entity->guid, "", 0, $annotation);
+add_to_river('annotation/annotate', 'comment', $user->guid, $entity->guid, "", 0, $annotation);
 
 // Forward to the page the action occurred on
 forward($_SERVER['HTTP_REFERER']);

actions/email/save.php

@@ -23,7 +23,7 @@
 }
 
 if ($user) {
-	if (strcmp($email, $user->email)!=0) {
+	if (strcmp($email, $user->email) != 0) {
 		if (!get_user_by_email($email)) {
 			if ($user->email != $email) {
 

actions/friends/add.php

@@ -2,8 +2,8 @@
 /**
  * Elgg add friend action
  *
- * @package Elgg
- * @subpackage Core
+ * @package Elgg.Core
+ * @subpackage Friends.Management
  */
 
 // Ensure we are logged in
@@ -21,13 +21,13 @@
 		$errors = true;
 	}
 } catch (Exception $e) {
-	register_error(sprintf(elgg_echo("friends:add:failure"),$friend->name));
+	register_error(sprintf(elgg_echo("friends:add:failure"), $friend->name));
 	$errors = true;
 }
-if (!$errors){
+if (!$errors) {
 	// add to river
-	add_to_river('friends/river/create','friend',get_loggedin_userid(),$friend_guid);
-	system_message(sprintf(elgg_echo("friends:add:successful"),$friend->name));
+	add_to_river('friends/river/create', 'friend', get_loggedin_userid(), $friend_guid);
+	system_message(sprintf(elgg_echo("friends:add:successful"), $friend->name));
 }
 
 // Forward back to the page you friended the user on

actions/friends/addcollection.php

@@ -1,12 +1,9 @@
 <?php
-
 /**
  * Elgg collection add page
  *
- * @package Elgg
- * @subpackage Core
-
-
+ * @package Elgg.Core
+ * @subpackage Friends.Collections
  */
 
 //must be logged in
@@ -16,15 +13,15 @@
 $friends = get_input('friends_collection');
 
 //first check to make sure that a collection name has been set and create the new colection
-if($collection_name){
+if ($collection_name) {
 
 	//create the collection
 	$create_collection = create_access_collection($collection_name, get_loggedin_userid());
 
 	//if the collection was created and the user passed some friends from the form, add them
-	if($create_collection && (!empty($friends))){
+	if ($create_collection && (!empty($friends))) {
 		//add friends to the collection
-		foreach($friends as $friend) {
+		foreach ($friends as $friend) {
 			add_user_to_access_collection($friend, $create_collection);
 		}
 	}

actions/friends/deletecollection.php

@@ -1,12 +1,9 @@
 <?php
-
 /**
  * Elgg friends: delete collection action
  *
- * @package Elgg
- * @subpackage Core
-
-
+ * @package Elgg.Core
+ * @subpackage Friends.Collections
  */
 
 // Make sure we're logged in (send us to the front page if not)

actions/friends/editcollection.php

@@ -1,10 +1,9 @@
 <?php
-
 /**
  * Elgg collection add page
  *
- * @package Elgg
- * @subpackage Core
+ * @package Elgg.Core
+ * @subpackage Friends.Collections
  */
 
 $collection_id = get_input('collection_id');

actions/friends/remove.php

@@ -2,8 +2,8 @@
 /**
  * Elgg remove friend action
  *
- * @package Elgg
- * @subpackage Core
+ * @package Elgg.Core
+ * @subpackage Friends.Management
  */
 
 // Ensure we are logged in
@@ -18,7 +18,7 @@
 try{
 	if ($friend instanceof ElggUser) {
 		get_loggedin_user()->removeFriend($friend_guid);
-	} else{
+	} else {
 		register_error(sprintf(elgg_echo("friends:remove:failure"), $friend->name));
 		$errors = true;
 	}

actions/likes/add.php

@@ -2,14 +2,15 @@
 /**
  * Elgg add like action
  *
- * @package Elgg
+ * @package Elgg.Core
+ * @subpackage Likes
  */
 
 gatekeeper();
 $entity_guid = (int) get_input('guid');
 
 //check to see if the user has already liked the item
-if (elgg_annotation_exists($entity_guid, 'likes')){
+if (elgg_annotation_exists($entity_guid, 'likes')) {
 	system_message(elgg_echo("likes:alreadyliked"));
 	forward($_SERVER['HTTP_REFERER']);
 }
@@ -53,8 +54,9 @@
 }
 
 system_message(elgg_echo("likes:likes"));
+
 //add to river
-add_to_river('annotation/annotatelike','likes',$user->guid,$entity->guid, "", 0, $annotation);
+add_to_river('annotation/annotatelike', 'likes', $user->guid, $entity->guid, "", 0, $annotation);
 
 // Forward back to the page where the user 'liked' the object
 forward($_SERVER['HTTP_REFERER']);

actions/likes/delete.php

@@ -2,7 +2,8 @@
 /**
  * Elgg delete like action
  *
- * @package Elgg
+ * @package Elgg.Core
+ * @subpackage Likes
  */
 
 // Ensure we're logged in

actions/login.php

@@ -45,20 +45,20 @@
 	}
 } else {
 	register_error(elgg_echo('loginerror'));
-//	// let a plugin hook say why login failed or react to it.
-//	$params = array(
-//		'username' => $username,
-//		'password' => $password,
-//		'persistent' => $persistent,
-//		'user' => $user
-//	);
-//
-//	// Returning FALSE to this function will generate a standard
-//	// "Could not log you in" message.
-//	// Plugins should use this hook to provide details, and then return TRUE.
-//	if (!trigger_plugin_hook('failed_login', 'user', $params, FALSE)) {
-//		register_error(elgg_echo('loginerror'));
-//	}
+	//	// let a plugin hook say why login failed or react to it.
+	//	$params = array(
+	//		'username' => $username,
+	//		'password' => $password,
+	//		'persistent' => $persistent,
+	//		'user' => $user
+	//	);
+	//
+	//	// Returning FALSE to this function will generate a standard
+	//	// "Could not log you in" message.
+	//	// Plugins should use this hook to provide details, and then return TRUE.
+	//	if (!trigger_plugin_hook('failed_login', 'user', $params, FALSE)) {
+	//		register_error(elgg_echo('loginerror'));
+	//	}
 }
 
 forward(REFERRER);

actions/register.php

@@ -14,7 +14,7 @@
 $password2 = get_input('password2');
 $email = get_input('email');
 $name = get_input('name');
-$friend_guid = (int) get_input('friend_guid',0);
+$friend_guid = (int) get_input('friend_guid', 0);
 $invitecode = get_input('invitecode');
 
 if ($CONFIG->allow_registration) {

actions/user/language.php

@@ -18,7 +18,7 @@
 }
 
 if (($user) && ($language)) {
-	if (strcmp($language, $user->language)!=0) {
+	if (strcmp($language, $user->language) != 0) {
 		$user->language = $language;
 		if ($user->save()) {
 			system_message(elgg_echo('user:language:success'));

actions/user/password.php

@@ -18,8 +18,8 @@
 	$user = get_entity($user_id);
 }
 
-if (($user) && ($password!="")) {
-	if (strlen($password)>=4) {
+if (($user) && ($password != "")) {
+	if (strlen($password) >= 4) {
 		if ($password == $password2) {
 			$user->salt = generate_random_cleartext_password(); // Reset the salt
 			$user->password = generate_user_password($user, $password);

actions/user/spotlight.php

@@ -2,13 +2,14 @@
 /**
  * Close or open spotlight.
  *
- * @package Elgg
- * @subpackage Core
+ * @package Elgg.Core
+ * @subpackage Spotlight
+ * @todo This is deprecated in 1.8
  */
 
 gatekeeper();
 
-$closed = get_input('closed','true');
+$closed = get_input('closed', 'true');
 if ($closed != 'true') {
 	$closed = false;
 } else {

actions/useradd.php

@@ -25,7 +25,7 @@
 try {
 	$guid = register_user($username, $password, $name, $email, TRUE);
 
-	if (((trim($password) != "") && (strcmp($password, $password2)==0)) && ($guid)) {
+	if (((trim($password) != "") && (strcmp($password, $password2) == 0)) && ($guid)) {
 		$new_user = get_entity($guid);
 		if (($guid) && ($admin)) {
 			$new_user->makeAdmin();
@@ -35,9 +35,13 @@
 		$new_user->created_by_guid = get_loggedin_userid();
 		set_user_validation_status($new_user->getGUID(), TRUE, 'admin_created');
 
-		notify_user($new_user->guid, $CONFIG->site->guid, elgg_echo('useradd:subject'), sprintf(elgg_echo('useradd:body'), $name, $CONFIG->site->name, $CONFIG->site->url, $username, $password));
+		$subject = elgg_echo('useradd:subject');
+		$body = sprintf(elgg_echo('useradd:body'), $name,
+			$CONFIG->site->name, $CONFIG->site->url, $username, $password);
 
-		system_message(sprintf(elgg_echo("adduser:ok"),$CONFIG->sitename));
+		notify_user($new_user->guid, $CONFIG->site->guid, $subject, $body);
+
+		system_message(sprintf(elgg_echo("adduser:ok"), $CONFIG->sitename));
 	} else {
 		register_error(elgg_echo("adduser:bad"));
 	}