New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
master: queries executed pre plugin boot #11932
Comments
The problem is site secret. @mrclay doesn't want it in boot cache
These shouldn't be an issue with persistent cache (memcache or redis) |
My feeling was that boot was reasonably optimized when I left it (starting to be a ton of work and regressions for marginal gain). An extra and fast query to keep a master key out of caches seems worth it...put it in settings.php. When I looked last views to render a full page were a pain point, so try not to do it :) |
I agree that gains are marginal at this point. |
The main reason i put it here was, because i analyzed the current need for queries. These queries mentioned were the result after i fixed a few bugs which resulted in having somewhere between 40 - 50 queries... so me solving them to get it back to 7 was pretty useful. This is what is left. I personally think having the plugin entities not cached could still be a bug. I will investigate that somewhat further. The rest is fine by me. Persistent entity caches probably will solve the site and user entity (i am not able to test that). |
No extra work needed at the moment |
An Elgg boot sequence will take (with all caches enabled) 7 queries.
After this plugin logic happens
In the shutdown sequence 3 write queries happen:
prev_last_action
last_action
Any ideas which queries are candidates for reduction? I think
If you want to check for yourself, pull #11931, as that already fixes a lot of unnecessary queries.
The text was updated successfully, but these errors were encountered: