Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elgg3: custom_index vs. activity plugins index page and plugin priority issue #12191

Closed
iionly opened this issue Oct 3, 2018 · 2 comments
Closed
Milestone

Comments

@iionly
Copy link
Contributor

iionly commented Oct 3, 2018

I see a strange issue with plugin priority in connection with custom_index and activity plugins.

I wondered why I don't get the custom_index index page but always only the activity page as index. Then I saw that custom_index is above activity in the plugin list so I placed custom_index below activity. STILL I got the activity page as index page. THEN I noticed that for whatever reason the plugin order has changed and custom_index got placed above the activity plugin!

So, the plugin order of these two plugins is not saved as expected. Additionally, the priority requirement (activity above custom_index) as defined in manifest.xml of custom_index wasn't followed correctly on site installation. But after disabling custom_index you can't enable it anymore because now custom_index wants to be placed below the activity plugin but when trying to fix the order it's not saved.

So, there's at least a problem with activity and custom_index. I can't say yet if the problem also occurs with other plugins.

@iionly
Copy link
Contributor Author

iionly commented Oct 3, 2018

With activity plugin disabled I could re-activate the custom_index plugin. And flushing the cache after changing the order (with activity plugin still disabled) seemed to have somehow overriden the priority issue with custom_index. After re-activating the activity plugin the order was kept as expected.

So, it might be that a priority requirement of a plugin blocks the re-ordering of a plugin (even if the plugin order is wrong to begin with) instead of re-checking the requirement after the re-ordering.

@jdalsem
Copy link
Member

jdalsem commented Jan 11, 2019

i am unable to reproduce this issue. closing this for now

@jdalsem jdalsem closed this as completed Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants