Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit cache logic #14595

Open
jdalsem opened this issue Apr 15, 2024 · 1 comment
Open

Revisit cache logic #14595

jdalsem opened this issue Apr 15, 2024 · 1 comment
Milestone

Comments

@jdalsem
Copy link
Member

jdalsem commented Apr 15, 2024

We now have various classes and storages for caches. We should use composite caches for storage. Helper classes should only differentiate between purposes of these caches. Currently we have some inconsistencies in how these caches exist. We also need to take a look on the ease of use of the caches with regard of DI.

For @jeabakker we need to have a look at the Preloader logic in relation to caches... don't know why exactly, but we can still have a look :)

@jdalsem jdalsem added this to the 6.x milestone Apr 15, 2024
@jeabakker
Copy link
Member

public function __construct(EntityCache $entity_cache) {
$this->_callable_cache_checker = function ($guid) use ($entity_cache) {
return $entity_cache->load($guid);
};
$this->_callable_entity_loader = function ($options) {
return Entities::find($options);
};
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants