database split logic is corrupted (Trac #1996)

[elgg-gitbot]

Original ticket http://trac.elgg.org/ticket/1996 on 40214568-08-20 by trac user bios, assigned to unknown.

Elgg version: 1.7

Despite the fact that logic for splitting DB reads/writes is laid in settings.php and database.php (by $CONFIG->db->split = true; key in settings), core does not supports this feature correctly.

There is next logic in file "/engine/lib/database.php" at lines 30-52:

if ($dblinkname != "readwrite" && isset($CONFIG->db[$dblinkname])) {
        if (is_array($CONFIG->db[$dblinkname])) {
            $index = rand(0,sizeof($CONFIG->db[$dblinkname]));
            $dbhost = $CONFIG->db[$dblinkname][$index]->dbhost;
            $dbuser = $CONFIG->db[$dblinkname][$index]->dbuser;
            $dbpass = $CONFIG->db[$dblinkname][$index]->dbpass;
            $dbname = $CONFIG->db[$dblinkname][$index]->dbname;
        } else {
            $dbhost = $CONFIG->db[$dblinkname]->dbhost;
            $dbuser = $CONFIG->db[$dblinkname]->dbuser;
            $dbpass = $CONFIG->db[$dblinkname]->dbpass;
            $dbname = $CONFIG->db[$dblinkname]->dbname;
        }
    } else {
        $dbhost = $CONFIG->dbhost;
        $dbuser = $CONFIG->dbuser;
        $dbpass = $CONFIG->dbpass;
        $dbname = $CONFIG->dbname;
    }

    // Connect to database
    if (!$dblink[$dblinkname] = mysql_connect($CONFIG->dbhost, $CONFIG->dbuser, $CONFIG->dbpass, true)) {

Despite that connection settings are prepared in variables $dbhost, $dbuser, etc. correctly, those variables are not used and connection established using direct values from $CONFIG.

Same situation can be seen in file "/simplecache/view.php" at line 25:

if ($mysql_dblink = mysql_connect($CONFIG->dbhost,$CONFIG->dbuser,$CONFIG->dbpass, true)) {

split logic isn`t used at all.

[elgg-gitbot]

cash wrote on 40215128-12-16

This ticket is a duplicate of #1349 - split table support has not been added to Elgg - we should add some documentation so that people don't misinterpret what's there as full support.

[elgg-gitbot]

Milestone changed to Unscheduled by cash on 40215128-12-16