Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put all friends related stuff into a plugin #7874

Closed
jdalsem opened this issue Feb 7, 2015 · 8 comments
Closed

Put all friends related stuff into a plugin #7874

jdalsem opened this issue Feb 7, 2015 · 8 comments

Comments

@jdalsem
Copy link
Member

jdalsem commented Feb 7, 2015

Discussed in multiple tickets, i suggest we make some effort to move all friends related stuff (UI, access, related views, actions) all into a separate plugin.

Elgg 2.0 is a nice moment to do this. It could make the core more lightweight and allows Elgg to be better useful in communities where the friends concept is not needed (or even a burden).

@juho-jaakkola
Copy link
Member

I'm afraid it would be extremely difficult to move everything into a plugin. But we could start by moving all the user facing features.

This was actually done once (by my ex-workmate), but reverted shortly after. I haven't yet searched for the reason.

@jdalsem
Copy link
Member Author

jdalsem commented Feb 9, 2015

What would be the difficult part?

@juho-jaakkola
Copy link
Member

One issue is that should all plugins always check elgg_is_plugin_active('friends') before adding Friends to the filter menu? That doesn't seem right.

@juho-jaakkola
Copy link
Member

This issue has a good summary: #3445

@jdalsem
Copy link
Member Author

jdalsem commented Feb 10, 2015

One issue is that should all plugins always check elgg_is_plugin_active('friends') before adding Friends to the filter menu? That doesn't seem right.

That is why i suggested #7873

@ewinslow
Copy link
Contributor

@jdalsem is this something you still want to get to? I'm not sure I see the planning/persuading/testing/etc. happening this month.

@ewinslow ewinslow removed this from the Elgg 2.0.x milestone May 30, 2015
@jdalsem
Copy link
Member Author

jdalsem commented Jun 1, 2015

One issue is that should all plugins always check elgg_is_plugin_active('friends') before adding Friends to the filter menu? That doesn't seem right.

That is why i suggested #7873

Still need some feedback on the above comment and ticket before i can proceed with this

@jdalsem
Copy link
Member Author

jdalsem commented Jun 26, 2015

Closing this as #7873 did not get anybody enthousiastic

@jdalsem jdalsem closed this as completed Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants