Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Github Integration #140

Closed
wants to merge 3 commits into from
Closed

Conversation

hypeJunction
Copy link
Contributor

  • Allows importing github releases when plugin project is first created
  • Allows releases to be pushed via webhooks from Github

@hypeJunction
Copy link
Contributor Author

Here is the first stab. I haven't had a chance to test the webhooks integration - need an Elgg installation with community plugins installed on the server somewhere (if anyone has time to deploy it somewhere, that would be appreciated).

}
} else if ($_FILES['upload']['error'] == UPLOAD_ERR_OK) {
$release = $plugin_project->addReleaseFromUpload('upload', [
'release_notes' => get_input('release_notes', ''),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to wrap with plugins_strip_tags() Done in PluginProject::addRelease*

@hypeJunction hypeJunction changed the title Github Integration WIP Github Integration May 24, 2016
Refactors the project form view for readability. Moves images segment into its
own view
Plugin owners are now given an option to import plugin releases from github
@hypeJunction
Copy link
Contributor Author

The working demo is at http://pragueprogrammes.com/demo/
Username is plugin_author. Password is Elgg plus three digits of this PR number.

There is currently a slight problem with releases made by scripts (things should work fine with manual releases on Github). http://stackoverflow.com/questions/37437581/listening-to-release-asset-changes-with-github-webhooks

@hypeJunction
Copy link
Contributor Author

@jdalsem @jeabakker Could you take it for a spin with one of your plugins?
I will need to update my release workflow to first create a draft, and then publish once the upload finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants