Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use AppDomain.Current.BaseDirectory instead of Assembly.Location for the sake of Fody.Costura #200

Merged
merged 4 commits into from
Jun 20, 2021

Conversation

MihailsKuzmins
Copy link
Collaborator

Issue #199.

  • created PathUtils which return AppDomain.Current.BaseDirectory is the location of an assembly is "";
  • reuse the PathUtils where assembly.location was used

@paulushub paulushub linked an issue Jun 19, 2021 that may be closed by this pull request
@paulushub
Copy link
Contributor

@MihailsKuzmins Thanks for the contributions. Please add XML documentation to the public class and methods.

@MihailsKuzmins
Copy link
Collaborator Author

@paulushub, thank you for the comment. Indeed I forgot about it. So now I have added some docs for the PathUtils. Could you please check whether or not the provided description is ok?

@paulushub paulushub merged commit a4be0c8 into ElinamLLC:master Jun 20, 2021
@paulushub
Copy link
Contributor

週末も仕事しているの?

@MihailsKuzmins
Copy link
Collaborator Author

週末も仕事しているの?

普段は、週末は趣味と「github」のときですが、時々働かなければいけません。致し方ありません。プログラミングは趣味ですから、構いません(笑笑)。使っているソフトは良くなって、よかったです。平日、週末かどうか関係ないです。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use SharpVectors with Fody.Costura
3 participants