-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit tests for PathUtils #209
Conversation
@MihailsKuzmins If possible, avoid testing private methods. |
@paulushub-san, yes, I know it is not a good practice, but I had a problem with In all projects there was an Thank you for the invitation. I have accepted it. By the way, what type of merge do you prefer? In my repositories I usually use squash, but I see that in this repository just a merge commit is used. So this is the preferred way of merging, right? |
I usually do not like sharing resources between projects, so that you can always move project without much problems.
Just a suggestion not a request, so go ahead - try the merge commit, it is the default and easy to tract changes. 😄 |
all right then. Thank you for the review 😄. Let us keep the tests not signed for now. Hopefully we will not need a lot of |
I could look into it with active committers. Long ago, someone contributed AppVeyor action, but I did not follow with it since I was the only active committer and have no need for automated Nuget package generation. |
assembly.Location
as an input parameterCombine
,GetAssemblyPath
andGetAssemblyFileName