Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase contrast on dark variant (or another variant with better contrast) #156

Open
alexanderadam opened this issue Jun 18, 2021 · 3 comments

Comments

@alexanderadam
Copy link

alexanderadam commented Jun 18, 2021

This theme is fantastic!
For real. I looove it!

What I love is the combination of dark backgrounds and bright colourful highlights.
It gives great visibility and a wonderful look.
And gradients! You really added some beautiful gradients!

There are some components without a proper contrast ration though.
Therefore it would be great if the contrast could be slightly increased.

Some examples:

depending on light and monitors the hover states in menus are barely distinguishable:

Gnome Menu


It's similar on the hover state of Nautilus favourites (Documents is hovered):

Screenshot from 2021-06-18 19-50-49


the font could be a bit lighter. This is a screenshot from unfocussed Nautilus — it looks a bit washed out, doesn't it?
Maybe it would be better to darken / desaturate the selected background colour instead of changing the font colour?

Screenshot from 2021-06-18 14-43-34


Also boxes, controls and borders in the Gnome Extensions overview are barely distinguishable (except the red error rectangle 😆). Somebody with limited sight probably won't recognize the toggles.

Screenshot from 2021-06-18 19-18-09


And the × for closing a window as well:

Screenshot from 2021-06-18 19-20-46


Or the × for closing a Nautilus tab (closing the Desktop tab is difficult if you can barely see the ×):

Screenshot from 2021-06-18 19-48-25


The white checkmark within the bright green square (show sidebar) is also difficult to distinguish (Nautilus menu).
Would it be possible to make the menu more distinguishable from the background (i.e. a bright/colourful dropshadow or a border like the in the selected tab or a slightly different background colour or something else)?
And the unchecked box above the green one is barely visible again.

Screenshot from 2021-06-18 19-42-08


The white colour of Delete on this bright orange neither has a good contrast ratio. Maybe a dark font colour would be better?:

Screenshot from 2021-06-18 21-26-48


This is from the file saving dialogue of Firefox when you try to create a new directory. The word Save is okayish (maybe a dark font would be better) but Create is again very difficult to read:

Screenshot from 2021-06-19 11-26-03


Activated week numbers in calender are also a bit difficult to read but the event description (Chaostreff Zürich on the bottom) is not better. The highlighted days aren't circles but rather eggs. I'm not sure whether this is part of the theme, though. 😆

Screenshot from 2021-06-18 19-59-58


This is a button when setting up DejaDup (maybe a dark font colour might be better if the background is this bright?).

Screenshot from 2021-06-18 20-18-48

Another unlucky colour combination is the same button on hover:

Screenshot from 2021-06-18 20-28-52


This is the Nautilus progress dialogue. The checkmark has a border around itself but it's barely visible as well:

Screenshot from 2021-06-19 11-26-03


PS: Maybe the icons could be linked in the theme readme and vice versa
PPS: Can you recommend a matching cursor theme?

@pruneaue
Copy link

Seems like i havent looked into this as much as you have, but i got to a satisfying enough point by tweaking the colors of the text in the config file (/usr/share/themes/Sweet-Dark-v40/gtk-4.0/gtk-dark.css).

@alexanderadam
Copy link
Author

i got to a satisfying enough point by tweaking the colors of the text in the config file (/usr/share/themes/Sweet-Dark-v40/gtk-4.0/gtk-dark.css).

Maybe you should consider creating a Pull Request then with your changes.
I'm sure @EliverLara would be glad about some help.

@pruneaue
Copy link

i got to a satisfying enough point by tweaking the colors of the text in the config file (/usr/share/themes/Sweet-Dark-v40/gtk-4.0/gtk-dark.css).

Maybe you should consider creating a Pull Request then with your changes. I'm sure @EliverLara would be glad about some help.

imo it made it look worse (albeit more usable) so I see why they made it the way it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants