Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme settings need cleanup #11

Closed
Cam opened this issue Sep 25, 2017 · 4 comments
Closed

Theme settings need cleanup #11

Cam opened this issue Sep 25, 2017 · 4 comments
Milestone

Comments

@Cam
Copy link
Member

Cam commented Sep 25, 2017

The theme settings have reverted to an old version. We'll need to manually clean them up for the new methods.

@Cam
Copy link
Member Author

Cam commented Sep 25, 2017

Theme info proposal;

 {
    "name": "theme_info",
    "theme_name": "Concrete",
    "theme_author": "Elkfox",
    "theme_version": "2.0.0",
    "theme_documentation_url": "https://elkfox.github.io/Concrete/",
    "theme_support_email": "help@elkfox.com"
  }

@georgebutter
Copy link

I'll add this bit in now.

@georgebutter
Copy link

Do we remove the color options? I feel like changing colours won't be used by most merchants. The settings should all be merchant focused really.

@Cam
Copy link
Member Author

Cam commented Oct 22, 2017

Yeah I think so. There should be minimal colour config available in the base framework.

@georgebutter georgebutter added this to the 2.0.2 milestone Oct 31, 2017
@georgebutter georgebutter mentioned this issue Nov 3, 2017
13 tasks
Cam pushed a commit that referenced this issue Aug 2, 2018
entry script should be theme.js instead of index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants