Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popups need updating to latest #16

Closed
Cam opened this issue Oct 11, 2017 · 5 comments
Closed

Popups need updating to latest #16

Cam opened this issue Oct 11, 2017 · 5 comments
Assignees
@Cam
Labels
enhancement 👌
Milestone
2.1

Comments

@Cam
Copy link
Member

Cam commented Oct 11, 2017

I'll update these myself soon 👍
@Cam Cam self-assigned this Oct 11, 2017
@georgebutter
Copy link

I think they are already?

@Cam
Copy link
Member Author

Cam commented Oct 13, 2017

They are mostly. But I had been working on some new functionality and efficiency that I need to roll in.

@Cam Cam closed this as completed Oct 13, 2017
@Cam Cam reopened this Oct 13, 2017
@Cam
Copy link
Member Author

Cam commented Oct 13, 2017

Oh, I also need to set up the main project for the popup system.

@georgebutter
Copy link

https://github.com/Elkfox/Concrete-Popups

@georgebutter georgebutter added this to the 2.0.2 milestone Oct 31, 2017
@georgebutter georgebutter mentioned this issue Nov 3, 2017
Closed
13 tasks
@Cam
Copy link
Member Author

Cam commented Nov 5, 2017

Lovely 😄 ...let's roll this in to Concrete ✌🏼

Cam pushed a commit that referenced this issue Aug 2, 2018
@tauthomas01
Add responsive images (#16)
618f2b5 
* Created a snippet to use responsive images

* Renamed filename, added responsive bg-image

* Add comments and clean up

* Remove comments

* Add more comments

* Code review, removed attributes and pieces of ode

* Removed the bgset styling into a separate module

* Used 1 container instead of 2 containers

* Revert one image to regular implentation and fix comments

* Fix comment and change the format padding-top

* Clean up conditions

* Add dashes to remove whitespaces, removed unnecessary classes and replace image.master

* Add dashes to avoid whitespaces

* Renamed width & height to max_height, max_width + fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cam Cam

Labels
enhancement 👌
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
3 participants
@georgebutter @Cam @oscarstranger