Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge responsive-image and responsive-background-image snippets #71

Closed
oscarstranger opened this issue Jun 13, 2018 · 0 comments
Closed

Merge responsive-image and responsive-background-image snippets #71

oscarstranger opened this issue Jun 13, 2018 · 0 comments
Labels
v3x 🚧 Concrete v3x built on Slate v1
Milestone
3.0.0

Comments

@oscarstranger
Copy link

  • Merge lazy loading codebases for responsive image & background image snippets
  • Default should probably be image, unless a ratio variable is set then use background-image
@oscarstranger oscarstranger added the v3x 🚧 Concrete v3x built on Slate v1 label Jun 13, 2018
@oscarstranger oscarstranger mentioned this issue Jun 13, 2018
Closed
@oscarstranger oscarstranger added this to the 3.0.0 milestone Jun 26, 2018
Cam pushed a commit that referenced this issue Aug 2, 2018
@t-kelly
Merge pull request #71 from Shopify/fix-contact-form-ref
d96edaf 
Fix reference to form.phone in contact form
@Cam Cam closed this as completed Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v3x 🚧 Concrete v3x built on Slate v1
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@Cam @oscarstranger