Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code style and obvious issues #1

Merged
merged 1 commit into from Jan 18, 2018
Merged

Conversation

rubenwardy
Copy link
Contributor

@rubenwardy rubenwardy commented Jan 17, 2018

  • Replace deprecated usage of getpos and minetest.env
  • Make function local and follow Lua naming convention
  • Use minetest.after instead of globalstep (more efficient)
  • Fix indentation

@rubenwardy
Copy link
Contributor Author

Question: what is player.tag supposed to be? You can't store data in userdata, and there is no tag property. This means that not player.tag will always be true

Copy link

@stujones11 stujones11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM a good start, anyway :)

@Elkien3
Copy link
Owner

Elkien3 commented Jan 18, 2018

I'm actually not sure what I meant by player.tag. originally I actually had two separate mods, that bit was from the "taghide" one I whipped up basically the day I learned it was possible. anyhow, thanks for the PR

@Elkien3 Elkien3 merged commit 883e9e2 into Elkien3:master Jan 18, 2018
@rubenwardy rubenwardy deleted the patch-1 branch January 19, 2018 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants