New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Builder documentation needs return information #2512
Comments
Unsure if there are other parts of the database documentation that need this information too, but there most likely are. |
Yes, the documentation I referred to was in fact the one in this repo and not the 2.1.3 one. I'll take a look and see what I can do. I've asked around briefly on IRC and nobody seems quite sure about the precise return values. I can simulate a successful database write and |
Anything you need to know about return values is in the source code. |
Most query 'building' methods return $this (the query builder object) to be able to chain those methods. Generally, when the query has been 'build', then the query is excecuted with one of the query excecuting methods e.g. insert(), update(),replace(), delete(), etc. Most return a result object, but indeed can return a boolean or query-string as well, which should be better documented.
|
I will go through the database docs ... there could be room for improvement! ps Not sure whether to consider documentation changes a bug or a feature, hence the waffling on the labels :-/ |
It's neither. |
User Guide update - Query Builder (fixes #2512)
1) Changed the grouping for better readability, in the query builder writeup 2) Added return value descriptors for all methods 3) Added default setting to query builder configuration writeup. The TOC sidebar is much better than before, though still a bit messy. This will need fixing with the sphinx theme update, being done separately. Signed-off-by:James L Parry <jim_parry@bcit.ca>
Close bcit-ci#2512 Related: bcit-ci#3396
The documentation for the Query Builder needs information on what the various functions return in different scenarios (success/failure).
The text was updated successfully, but these errors were encountered: