Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userguide/query builder #3396

Merged
merged 4 commits into from
Dec 8, 2014
Merged

Conversation

jim-parry
Copy link
Contributor

No description provided.

Removed API stuff from the query builder page.
Added a new API reference page.
Updated the index to include the API ref in the TOC.
Started on the API reference page.
Signed-off-by:James L Parry <jim_parry@bcit.ca>
Fleshing out the API reference
Signed-off-by:James L Parry <jim_parry@bcit.ca>
Fleshing out the API reference
Signed-off-by:James L Parry <jim_parry@bcit.ca>
@narfbg
Copy link
Contributor

narfbg commented Dec 8, 2014

Why a separate API page? It's kind of useless when it's not combined with the actual explanations ...

@jim-parry
Copy link
Contributor Author

I made it a separate page because of the length, figuring that someone would want the how-to or the reference. Will combine over the next few days, as well as fix any optional parameters (per the other PR comments).

Integrated API reference with the regular query builder page.
Added square brackets for optional parameters.
Signed-off-by:James L Parry <jim_parry@bcit.ca>
@jim-parry
Copy link
Contributor Author

Fixed per your suggestions

narfbg added a commit that referenced this pull request Dec 8, 2014
@narfbg narfbg merged commit 75818df into bcit-ci:develop Dec 8, 2014
narfbg added a commit that referenced this pull request Dec 11, 2014
@narfbg
Copy link
Contributor

narfbg commented Dec 11, 2014

@jim-parry Just a note about $this->db->query() ... it doesn't always return CI_DB_result instances. If it executes a "write type" query such as INSERT or DELETE, then it will return boolean.

@jim-parry
Copy link
Contributor Author

Sorry about that.

@jim-parry jim-parry deleted the userguide/query_builder branch December 19, 2014 03:31
ghost pushed a commit to goreilly/CodeIgniter that referenced this pull request Jan 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants