Bug in 2.1-stable - language typo in Migrations library

[michaelbrooks]

This seems to have been fixed or made irrelevant in develop, but in 2.1-stable there is a bug in CI_Migration::latest().

lang and line are out of order, so when latest() is called and find_migrations() fails, there is a fatal PHP error.

[AgentConundrum]

I doubt this will be accepted. I noticed this error myself the other day, but it's already been fixed in the develop branch. AFAIK, patches are only supposed to be sent to the develop branch.

[michaelbrooks]

Yeah, I saw that changes are only supposed to be sent to develop. But then how do they do bug fixes in the stable branch?

[AgentConundrum]

A fair number of commits in the 2.1 branch mention backporting changes. I guess most of the time any new changes to the 2.1 line begin life either as changes made to 3.0, or that were raised as issues.

That said, I didn't think you necessarily needed to close the PR. I was simply mentioning that the developers were likely aware of the issue already. It seems like something that should have got pushed back, but realistically it's likely a rare edge case to try to run a migration without having first created at least one.

[narfbg]

3.0 is very close to a release and for that reason, it's highly unlikely that a 2.1.4 release will ever happen.

This doesn't mean that this PR shouldn't be accepted of course and you didn't need to close it. But for the above reasons I doubt that it would make a difference.

[michaelbrooks]

Oops, I actually didn't mean to close it.

I don't know whether I'll be upgrading to 3.0 in the near future (depends how different it is), and there must be others who will be using 2.1.x for a while yet.