Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated eth_account function #49

Closed
Elnaril opened this issue Mar 30, 2024 · 1 comment
Closed

Replace deprecated eth_account function #49

Elnaril opened this issue Mar 30, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Elnaril
Copy link
Owner

Elnaril commented Mar 30, 2024

The function eth_account.encode_structured_data() is deprecated in favour of eth_account.messages.encode_typed_data().

The UR SDK is still using encode_structured_data() in RouterCodec.create_permit2_signable_message and thus must be updated with encode_typed_data().

As a source of inspiration, one can look how it was used in the UniswapX SDK.
@Elnaril Elnaril added the good first issue Good for newcomers label Mar 30, 2024
Elnaril added a commit that referenced this issue Jun 17, 2024
@Elnaril
#49 - Replace deprecated eth_account function
ca2ce17
@Elnaril
Copy link
Owner Author

Elnaril commented Jun 17, 2024

Fixed with #65

@Elnaril Elnaril closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Elnaril