Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 bit build for Windows #62

Closed
xianwenchen opened this issue Sep 28, 2016 · 13 comments
Closed

64 bit build for Windows #62

xianwenchen opened this issue Sep 28, 2016 · 13 comments
Labels
Milestone

Comments

@xianwenchen
Copy link

I'm curious if it's possible to produce a 64 bit build for Windows. I'm actually interested in producing it myself, if you wouldn't mind helping me get started. :-)

@Eloston
Copy link
Member

Eloston commented Sep 28, 2016

I haven't tested it, but the code should be there to build it. Do you have some knowledge of Python? You'll need to add two lines to build.py:

  • Import CPUArch from buildlib.common
  • Set the target_arch attribute of builder to be CPUArch.x64

Then run build.py normally and hope for the best.

@xianwenchen
Copy link
Author

Thank you!

@woolyss
Copy link

woolyss commented Oct 4, 2016

Hello everybody,

Please, can you test new releases of 64-bit chromium with ungoogled-chromium patches?
https://chromium.woolyss.com/#windows-64-bit

For info, nik is the main developer of stable 64-bit Chromium versions, available over the Internet.
And chromium.woolyss.com is reliable source without ads.

@Eloston
Copy link
Member

Eloston commented Oct 4, 2016

Hi @woolyss, I really like your website. It has great info and binaries that I've used from time-to-time. Thanks :)

A few questions: Does nik's build use domain substitution or source cleaning? Did nik use buildlib, or include the patches in his own build process?

@woolyss
Copy link

woolyss commented Oct 4, 2016

Hello @Eloston, thank you very much. I made a simple resource and Nik has mainly improved it with its Chromium releases.

I am not Nik but I can try to answer you. I invited him to come here.

  1. He uses source cleaning.
  2. I do not know if he uses buildlib but he includes the patches in his own build process.

Nik does not use all patches because there are few limitations. Some of patches are not working because they are for GYP build system (fix-building-without-one-click-signin.patch and others) - Ref.: #16 (comment) - Nik compiles Chromium with GN build system and PGO optimization.

Anyway, good work @Eloston ! ;)

@chrme
Copy link
Contributor

chrme commented Oct 4, 2016

Hi @Eloston, i've used some of your patches from "patch_order" file only (some was failed and some i've disabled because of "trk" part and domain substitution).

@Eloston
Copy link
Member

Eloston commented Oct 4, 2016

@chrme @woolyss

I see. Well that's a bit unfortunate. Would you mind adding a disclaimer on the site saying that several patches and domain substitution are not used? Also, since you're using GN, I'm guessing you're using binaries provided by Google? If so, I would also like that to be mentioned in the disclaimer.

I may sound pedantic, but I think these differences are among the major features that ungoogled-chromium has to offer. The patches that depend on GYP are those that disable the more integrated features, and building without Google binaries gives users more certainty that Google isn't doing something behind our backs.

@woolyss
Copy link

woolyss commented Oct 4, 2016

@Eloston: Ok, I understand. I wrote a disclamer on the site.
https://chromium.woolyss.com/#windows-64-bit

Finally, can you compile a 64-bit version of ungoogled-chromium for Windows?
I think it could be better than our merged builds! ;)

@Eloston
Copy link
Member

Eloston commented Oct 4, 2016

@woolyss Thanks

Finally, can you compile a 64-bit version of ungoogled-chromium for Windows?
I think it could be better than our merged builds! ;)

Yeah I'm planning to do that as soon as I can.

@woolyss
Copy link

woolyss commented Oct 4, 2016

Yeah I'm planning to do that as soon as I can.

Nice! Thank you for your work and support.

@chrcoluk
Copy link

woolyss so what happened to your builds? I see no mention of it on your site.

@woolyss
Copy link

woolyss commented Nov 30, 2016

@chrcoluk, I have nothing against Eloston and its project but see my review at:
https://chromium.woolyss.com/?all=1#comment-1566
(note this link will display all comments. So the content can be slow to display)

Anyway you can download our 64-bit version (chromium-ungoogled.zip) at:
https://github.com/henrypp/chromium/releases/tag/v53.0.2785.143-r403382-win64

For info, you will find a site archive at:
https://web.archive.org/web/20161115065312/http://chromium.woolyss.com/#windows-64-bit-chocolatey

@Eloston
Copy link
Member

Eloston commented Dec 16, 2016

#147 implements this. Going to make x86 and x64 builds and upload them to the next tag.

@Eloston Eloston closed this as completed Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants