Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appearances path won't change after changing the character name #42

Closed
yuna0x0 opened this issue Apr 7, 2019 · 2 comments
Closed

Appearances path won't change after changing the character name #42

yuna0x0 opened this issue Apr 7, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@yuna0x0
Copy link
Member

yuna0x0 commented Apr 7, 2019

Describe the bug
A clear and concise description of what the bug is.

Appearances path won't change after changing the character name (ID) in project settings. It will just prepend the new name to appearances path.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error
  1. Open project settings in Naninovel -> Configuration context menu.
  2. Go to characters tab
  3. Change a character's name.
  4. Go into the character's detail settings
  5. Back to characters
  6. Change the character's name again
  7. See error

Expected behavior
A clear and concise description of what you expected to happen.

Appearances path should change to the new character name. Not prepend the new name to appearances path.

Screenshots
If applicable, add screenshots to help explain your problem.

Character name (ID) with "Angel"
螢幕快照 2019-04-07 上午9 15 22

Appearances path before changing the character name
螢幕快照 2019-04-07 上午9 15 16

Changing character name (ID) to "AngelNew"
螢幕快照 2019-04-07 上午9 15 38

See error
螢幕快照 2019-04-07 上午9 15 45

Naninovel version
Version of the engine as displayed in Naninovel -> About window, e.g.: 1.0.12-beta

v1.3.2-beta build 2019-03-08

Unity version
Specify Unity version you are using, e.g.: 2018.3.5f2.

2018.3.11f1

OS (when editor-related)
Which operating system you're running the editor under, e.g.: Windows 10

macOS 10.14.4

Platform
Which target platform you're using, e.g.: WebGL

PC, Mac & Linux Standalone (Mac OS X)

@yuna0x0 yuna0x0 added the bug Something isn't working label Apr 7, 2019
@elringus
Copy link
Member

elringus commented Apr 7, 2019

Well, yeah, that's kinda complicated. I'm currently re-writing the config system and it will handle this case when the appearance names are equal to the sprite names, but otherwise the names will still be lost when re-naming the actor. I will think if there is a way to handle that.

@elringus
Copy link
Member

elringus commented Apr 7, 2019

Fixed in v1.4.0-beta.

https://i.gyazo.com/6d6f1b09b448bd6854df395319e6592e.mp4

@elringus elringus closed this as completed Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants