Compute shard id start in epoch false #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianpascalau
previously approved these changes
Jun 4, 2020
SebastianMarian
previously approved these changes
Jun 4, 2020
sasurobert
dismissed stale reviews from SebastianMarian and iulianpascalau
via
e87c806
| err := errors.New("localErr") | ||
| args.LatestStorageDataProvider = &mock.LatestStorageDataProviderStub{ | ||
| GetCalled: func() (storage.LatestDataFromStorage, error) { | ||
| return storage.LatestDataFromStorage{}, err |
There was a problem hiding this comment.
Is this intended? Returning both useful data and error?
There was a problem hiding this comment.
It is not useful. It is a strict not a pointer to a struct. Only error is important for this
There was a problem hiding this comment.
yup, is not a pointer, missed that
iulianpascalau
previously approved these changes
Jun 8, 2020
SebastianMarian
previously approved these changes
Jun 9, 2020
sasurobert
dismissed stale reviews from SebastianMarian and iulianpascalau
via
7549301
SebastianMarian
approved these changes
Jun 16, 2020
iulianpascalau
approved these changes
Jun 18, 2020
LucianMincu
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.