-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute shard id start in epoch false #1867
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c5aaf35
start in epoch false and search new shard ID
sasurobert b0f9852
Merge branch 'development' into compute-shardID-startInEpoch-false
sasurobert ec2e0ed
Merge branch 'development' into compute-shardID-startInEpoch-false
sasurobert d1d042d
Merge branch 'development' into compute-shardID-startInEpoch-false
LucianMincu e87c806
fix unit test
sasurobert 448c5ee
Merge branch 'development' into compute-shardID-startInEpoch-false
sasurobert af3d4a3
Merge branch 'development' into compute-shardID-startInEpoch-false
sasurobert 7549301
fix for first start
sasurobert 4e14d41
Merge branch 'development' into compute-shardID-startInEpoch-false
sasurobert b6090b9
Merge branch 'development' into compute-shardID-startInEpoch-false
LucianMincu 64173e7
Merge branch 'development' into compute-shardID-startInEpoch-false
LucianMincu c008c9d
Merge branch 'development' into compute-shardID-startInEpoch-false
LucianMincu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended? Returning both useful data and error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not useful. It is a strict not a pointer to a struct. Only error is important for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, is not a pointer, missed that