Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename/Renamed containers, made them private #349

Merged
merged 6 commits into from
Aug 9, 2019

Conversation

sasurobert
Copy link
Contributor

made containers private. only interface is visible

Copy link
Contributor

@iulianpascalau iulianpascalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also rename containers from dataRetriever package?

@sasurobert sasurobert changed the title fix after review rename/Renamed containers, made them private Aug 8, 2019
@raduchis raduchis self-requested a review August 9, 2019 06:29
Copy link
Contributor

@raduchis raduchis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small name typo: NewpPeProcessor in the comment above the method

@iulianpascalau iulianpascalau merged commit df9e803 into development Aug 9, 2019
@iulianpascalau iulianpascalau deleted the EN-3350/Refactor-container-names branch August 9, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants