Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using Bun! #6

Merged
merged 80 commits into from
Sep 25, 2023
Merged

Start using Bun! #6

merged 80 commits into from
Sep 25, 2023

Conversation

Eltik
Copy link
Owner

@Eltik Eltik commented Sep 25, 2023

Large update!

  • Convert all sub-repos to use Bun.
  • Update mappings to have base providers (eg. Anime -> AniList, manga -> MangaDex, and light novels -> NovelUpdates)
  • Improve mapping accuracy
  • Allow for creating light novel epubs and uploading them to MixDrop!
  • Recode entire backend, authentication server, and Discord bot manager!
  • Update workflows
  • Remove bad providers (KASS, NovelBuddy, VyNovel, ReadLightNovels)
  • Add new info/meta/manga providers! (MangaFire, AniDB)
  • Add episode metadata for episode descriptions/ratings via TVDB, TMDB, and AniDB
  • QOL changes with console.log(), README.md's, and more
  • Use Eris instead of discord.js for the manager and recode how the manager works entirely
  • Remove the use of API keys

And lots more!

@gitguardian
Copy link

gitguardian bot commented Sep 25, 2023

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
5734266 Generic High Entropy Secret f113461 anify-backend-recode/src/mappings/impl/meta/tmdb.ts View secret
5734266 Generic High Entropy Secret d7fbe38 anify-backend/src/mappings/impl/meta/tmdb.ts View secret
5734266 Generic High Entropy Secret d7fbe38 anify-backend/src/mappings/impl/information/tmdb.ts View secret
6884440 Generic High Entropy Secret fbfd4aa anify-backend/src/mapping/impl/information/tvdb.ts View secret
6884440 Generic High Entropy Secret f113461 anify-backend-recode/src/mappings/impl/information/tvdb.ts View secret
6884440 Generic High Entropy Secret 19bc6e9 anify-backend-recode/src/mappings/impl/meta/tvdb.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

return undefined;
}

const apiID = env.CENSYS_ID ?? "d973cf60-4ce4-4746-962b-815ddfdebf80",

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical

The hard-coded value "d973cf60-4ce4-4746-962b-815ddfdebf80" is used as
authorization header
.
}

const apiID = env.CENSYS_ID ?? "d973cf60-4ce4-4746-962b-815ddfdebf80",
apiSecret = env.CENSYS_SECRET ?? "s6EUuA4Sfaajd8jDBJ17b4DaoPofjDe6";

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical

The hard-coded value "s6EUuA4Sfaajd8jDBJ17b4DaoPofjDe6" is used as
authorization header
.
@Eltik Eltik merged commit 629356d into main Sep 25, 2023
2 of 4 checks passed
@Eltik Eltik deleted the bun branch September 25, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants