Conversation
This is the second change that we were write in at the same time and our realisation have difference. To make sure it won't happen again, let's establish communication. |
Done. |
9994b16
to
37427ab
Compare
Rebased. Added some Fixes - my PLAYER_ENTERED_WORLD callback was crap before (whoops). Removing WIP tag, because I think it works very nicely. Still need to test it in a full raid though. |
044aabf
to
7e47cd4
Compare
aaand rebased |
…Lib and LibBanzai
7e47cd4
to
f9fb3a1
Compare
rebaserino - still working |
Since this is not getting merged, I'm replacing this with a Plugin https://github.com/Tremolo4/ElvUI_ThreatDisplayFix |
Threat display functionality was removed some time ago, presumably because UnitThreatSituation etc. are not present in 2.4.3.
I have implemented UnitThreatSituation using LibBanzai-2.0 and ThreatLib-2.0. Works surprisingly good!
The uOF threat element uses UNIT_THREAT_SITUATION_UPDATE, UNIT_THREAT_LIST_UPDATE which are also not present in 2.4.3. I replaced those with callbacks also from LibBanzai and ThreatLib. Works fine as well. ThreatLib callbacks are rate-limited (2 per second).
WIP, because I have not tested this in a raid yet. There are some debug prints still. Will report here again.