Skip to content
This repository has been archived by the owner on Jun 2, 2021. It is now read-only.

Threat display #272

Closed
wants to merge 4 commits into from
Closed

Threat display #272

wants to merge 4 commits into from

Conversation

Tremolo4
Copy link
Contributor

@Tremolo4 Tremolo4 commented Jul 28, 2017

Threat display functionality was removed some time ago, presumably because UnitThreatSituation etc. are not present in 2.4.3.

I have implemented UnitThreatSituation using LibBanzai-2.0 and ThreatLib-2.0. Works surprisingly good!

The uOF threat element uses UNIT_THREAT_SITUATION_UPDATE, UNIT_THREAT_LIST_UPDATE which are also not present in 2.4.3. I replaced those with callbacks also from LibBanzai and ThreatLib. Works fine as well. ThreatLib callbacks are rate-limited (2 per second).

WIP, because I have not tested this in a raid yet. There are some debug prints still. Will report here again.

@Loaal
Copy link
Contributor

Loaal commented Jul 28, 2017

This is the second change that we were write in at the same time and our realisation have difference. To make sure it won't happen again, let's establish communication.
Join our discord server where we can discuss that.

@Tremolo4
Copy link
Contributor Author

Tremolo4 commented Jul 28, 2017

Join our discord server where we can discuss that.

Done.
Looking forward to your solution (maybe mine is of some help still) :)

@Tremolo4 Tremolo4 force-pushed the threat_display branch 3 times, most recently from 9994b16 to 37427ab Compare July 29, 2017 02:36
@Tremolo4
Copy link
Contributor Author

Tremolo4 commented Jul 29, 2017

Rebased.

Added some Fixes - my PLAYER_ENTERED_WORLD callback was crap before (whoops).
Now includes full implementation of UnitThreatSituation (not needed for threat element).
According to my testing, there are no performance problems (regarding ThreatLib).

Removing WIP tag, because I think it works very nicely. Still need to test it in a full raid though.

@Tremolo4 Tremolo4 changed the title [WIP] Threat display Threat display Jul 29, 2017
@Tremolo4
Copy link
Contributor Author

Tremolo4 commented Aug 3, 2017

aaand rebased

@Tremolo4
Copy link
Contributor Author

rebaserino - still working

@Tremolo4 Tremolo4 closed this Dec 12, 2017
@Tremolo4 Tremolo4 deleted the threat_display branch December 12, 2017 21:03
@Tremolo4
Copy link
Contributor Author

Since this is not getting merged, I'm replacing this with a Plugin https://github.com/Tremolo4/ElvUI_ThreatDisplayFix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants