New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document PSR-6 cache adapters #14
Conversation
@Nyholm would it be wise to document asm89/twig-cache-extension#32 is merged now so this one also can get merged. |
I think you should mention that you have to install a package providing |
ping @EmanueleMinotto the PR with the adapter is merged, no release was tagged yet but this PR can be merged after that. |
thanks @rvanlaak, I'm waiting for a tag in the asm89/twig-cache-extension repo, after that I'll merge your PR :) |
Great! 👍 FYI: I've did some textual changes based on @Nyholm's feedback to clarify the relationship with the PSR-6, you think it is clear now too? |
|
||
```yml | ||
# app/config/config.yml | ||
twig_cache: | ||
service: cache_service # instance of Doctrine\Common\Cache\Cache | ||
service: cache_service # |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While waiting for asm89/twig-cache-extension:v1.3.0
, could you please add a description of allowed classes here or remove the #
too?
@EmanueleMinotto I've added classes to the README, still waiting on the tag to be released 👎 |
You can use the new adapter already, just do a |
asm89/twig-cache-extension#32 will introduce a new adapter that allows you to configure any cache pool that implements the
CacheItemPoolInterface
. This will introduce a lot of adapters to the Twig caching extension: http://php-cache.readthedocs.io/en/latest/This documentation PR can be merged once the other PR with the adapter is merged and
1.3.0
of the extension was released.