Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document PSR-6 cache adapters #14

Merged
merged 1 commit into from Jul 17, 2016

Conversation

rvanlaak
Copy link
Contributor

asm89/twig-cache-extension#32 will introduce a new adapter that allows you to configure any cache pool that implements the CacheItemPoolInterface. This will introduce a lot of adapters to the Twig caching extension: http://php-cache.readthedocs.io/en/latest/

This documentation PR can be merged once the other PR with the adapter is merged and 1.3.0 of the extension was released.

@rvanlaak
Copy link
Contributor Author

@Nyholm would it be wise to document psr/cache-implementation here too, instead of suggesting cache/adapter-bundle?

asm89/twig-cache-extension#32 is merged now so this one also can get merged.

@Nyholm
Copy link

Nyholm commented Jun 14, 2016

I think you should mention that you have to install a package providing psr/cache-implementation. The cache/adapter-bundle makes it easier to configure that package and add it as a Symfony service.

@rvanlaak
Copy link
Contributor Author

ping @EmanueleMinotto the PR with the adapter is merged, no release was tagged yet but this PR can be merged after that.

@EmanueleMinotto
Copy link
Owner

thanks @rvanlaak, I'm waiting for a tag in the asm89/twig-cache-extension repo, after that I'll merge your PR :)

@rvanlaak
Copy link
Contributor Author

Great! 👍 FYI: I've did some textual changes based on @Nyholm's feedback to clarify the relationship with the PSR-6, you think it is clear now too?


```yml
# app/config/config.yml
twig_cache:
service: cache_service # instance of Doctrine\Common\Cache\Cache
service: cache_service #
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While waiting for asm89/twig-cache-extension:v1.3.0, could you please add a description of allowed classes here or remove the # too?

@rvanlaak
Copy link
Contributor Author

rvanlaak commented Jun 28, 2016

@EmanueleMinotto I've added classes to the README, still waiting on the tag to be released 👎

@rvanlaak
Copy link
Contributor Author

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.667% when pulling 08cb5d3 on rvanlaak:psr6 into 37aa9e1 on EmanueleMinotto:master.

@EmanueleMinotto EmanueleMinotto merged commit fc30247 into EmanueleMinotto:master Jul 17, 2016
@EmanueleMinotto
Copy link
Owner

Fainally merged, @rvanlaak thank you very much for your effort! :)
What about #12 now?

@rvanlaak
Copy link
Contributor Author

You can use the new adapter already, just do a composer update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants