Widen ash
support up to 0.37
, and bump version to 0.13.1
.
#71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the comment left in
Cargo.toml
, we can support multiple (otherwise "breaking") versions ofash
, because very little ofash
's API surface is being interfaced with.I've tested the code with
ash
at0.35
,0.36
,0.37
and they all passcargo check
, but I don't have a macOS system to test that it actually runs - still, the API is so simple I can't imagine it breaking in a subtle way.Since this is backwards-compatible, I've only bumped the patch number in
ash-molten
's version, and we can continue to do so in the future to support moreash
versions.Something I'm not sure about is: should CI try all supported
ash
versions to avoid regressing?As for why I need this: bumping
wgpu
in Rust-GPU, forexample-runner-wgpu
, requiresash 0.37
, andash-molten
was keepingexample-runner-ash
onash 0.35
, leading to two builds ofash
(it's not the only cause of build duplication, but it was getting in the way).With this PR, I can unify those dependencies quite nicely (though, again, can't actually test native functionality on macOS).
Also, whoever lands this PR should publish the new version (I don't think I have the power to, but also I'd rather not touch that part).